Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LLM invoke error should not be raised #11141

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: LLM invoke error should not be raised #11141

merged 1 commit into from
Nov 26, 2024

Conversation

laipz8200
Copy link
Member

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 26, 2024
@laipz8200 laipz8200 changed the title fix(llm_node): Removes redundant exception logging fix: LLM invoke error should not be raised Nov 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 26, 2024
@laipz8200 laipz8200 merged commit 223a304 into main Nov 26, 2024
8 checks passed
@laipz8200 laipz8200 deleted the fix/removes-redundant-exception-logging branch November 26, 2024 12:56
@laipz8200 laipz8200 mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@snakevash snakevash snakevash approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laipz8200 @snakevash @crazywoola